Fix transform_points for empty arrays #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelson
reviewed
Apr 26, 2018
|
I'll clean up the formatting. I have trouble believing there's any knock on effects, since without this line you end up with an exception. |
|
@pelson It looks like master is having the same test failures (modulo the |
Empty arrays (i.e. one axis is size 0) were causing problems with transform_points since it was explicitly asking for index 0. Wrapping this in a check for the number of points seems to allow things to work just fine.
pelson
approved these changes
Jul 15, 2018
| &result[0, 0], &result[0, 1], &result[0, 2]) | ||
| # call proj.4. The result array is modified in place. This is only | ||
| # safe if npts is not 0. | ||
| if npts: |
There was a problem hiding this comment.
Would be lovely to have a unit test for this. Would you mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In matplotlib, calling:
plot([], [])is perfectly fine; in fact, this is required fortriplot()to work properly--in the case of no markers (or explicitly no lines), this is exactly what it does. Currently the following cases fail in CartoPy:plot([], [], transform=...)triplot()followed by asavefig(..., bbox_inches='tight')(i.e. Jupyter notebook inline)with the failure occurring in
CRS.tranform_points(). This is because it is trying to transform an array with a size of 0 for the first dimension.The easy solution is to add a guard on
nptsaround the call topj_transform(), which was explicitly passed arrays indexed to 0 on size 0 axes, which is invalid.Closes #1060.