-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update image tests for matplotlib 2.1. #1070
Conversation
Unfortunately, there are still 21 failing tests. 😭 |
I think we need to introduce some perceptual image hashing to ease the pain of graphical testing in I'm happy to make the approach we use in I know of other Thoughts @pelson... |
Yep, agreed. I considered doing the work myself instead of this PR. I don't really want to introduce a change to the tests that means we could not test with older versions of matplotlib - I'd like the thing to be additive, not substitutive. Pulling out the machinery from Iris into its own project is the obvious next step, and I think that is something we should focus on next. |
I'm not sure you want to update the barb/streamplot results before #1042, though I'm not sure which one has the greater effect. I don't see any of these ones failing on that PR with 2.1.1. |
OK, I'm going to take this one on the chin and merge #1042 even though the tests are failing. The reason I'm doing this is that: a) master's tests have been failing for way too long |
So I totally sent that last message to the wrong PR 🤣. I'm working on this PR, and decided to merge #1042 so that I can move this forwards. |
… fixing properly with imagehashing.
61111ae
to
d5b6296
Compare
🎉 - this brings the tests back online. I'm keen to address the testing issue once and for all in terms of truly reproducible image tests and data sources, but I'm reasonably content to address that in slower time. For now, we need to get the tests back up and passing. cc @dopplershift if you'd care to do the honours before the weekend's sprints 😉 ? |
🎉 |
Looks like a few tests were failing due to font differences, and others due to changes in underlying image sources.