Add all 60 zones of the UTM projection to the docs projection list #1103

kaedonkers · 2018-08-09T08:12:45Z

Rationale

In the projection list of the documentation the UTM projection is depicted using only one zone. It would be more informative to include all 60 zones of the projection in the list, side by side (similar to the example added in PR #954).

Implications

Rewrites make_projection.py to include options for multiple subplots as well as single plots. Multiple subplots have been utilised for both PlateCarree and UTM projections.
Closes issue #986.

…h UTM zone

kaedonkers · 2018-08-09T08:13:08Z

@pelson could you review this please?

stickler-ci · 2018-08-09T08:13:10Z

docs/make_projection.py

+
+def plate_carree_plot(i, nplots):
+    central_longitude = 0 if i == 1 else 180
+    ax = fig.add_subplot(1, nplots-1, i,


F821 undefined name 'fig'

Needed for generating plotting code.

stickler-ci · 2018-08-09T08:13:10Z

docs/make_projection.py

+    central_longitude = 0 if i == 1 else 180
+    ax = fig.add_subplot(1, nplots-1, i,
+                         projection=ccrs.PlateCarree(
+                         central_longitude=central_longitude))


E122 continuation line missing indentation or outdented

stickler-ci · 2018-08-09T08:13:10Z

docs/make_projection.py

+
+
+def utm_plot(i, nplots):
+    ax = fig.add_subplot(1, nplots-1, i,


F821 undefined name 'fig'

stickler-ci · 2018-08-09T08:13:10Z

docs/make_projection.py

-        for instance_args in SPECIAL_CASES.get(prj, [{}]):
-            prj_inst = prj(**instance_args)
+
+        if prj not in MULTI_PLOT_CASES:


E303 too many blank lines (2)

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

+            # Generate plotting code
+            code = textwrap.dedent("""
+            .. plot::
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

+
+                import matplotlib.pyplot as plt
+                import cartopy.crs as ccrs
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

+
+            code = textwrap.dedent("""
+            .. plot::
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

+                import cartopy.crs as ccrs
+
+                fig = plt.figure(figsize=(10, 3))
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

+                fig = plt.figure(figsize=(10, 3))
+
+                {func_code}
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T08:13:11Z

docs/make_projection.py

-\n""".format(width=width, proj_constructor=instance_creation_code,
-             coastline_resolution=COASTLINE_RESOLUTION.get(prj, '110m'))
+            """).format(nplots=nplots+1,
+                       func_code=func_code, func_name=func.__name__)


E128 continuation line under-indented for visual indent

stickler-ci · 2018-08-09T08:30:24Z

docs/make_projection.py

+
+def plate_carree_plot(i, nplots):
+    central_longitude = 0 if i == 1 else 180
+    ax = fig.add_subplot(1, nplots-1, i,


F821 undefined name 'fig'

stickler-ci · 2018-08-09T08:30:24Z

docs/make_projection.py

+            # Generate plotting code
+            code = textwrap.dedent("""
+            .. plot::
+


W293 blank line contains whitespace

stickler-ci · 2018-08-09T09:17:12Z

docs/make_projection.py

+
+def plate_carree_plot(i, nplots):
+    central_longitude = 0 if i == 1 else 180
+    ax = fig.add_subplot(1, nplots-1, i,


F821 undefined name 'fig'

QuLogic

This is mostly better, but there's something a bit off with the width. It seems like the existing plots were never too wide, but these new figures are too wide to fit and are shrunk down a bit, producing a slightly poorer looking figure.

Also, some minor stylistic issues below.

QuLogic · 2018-08-09T21:43:59Z

docs/make_projection.py

@@ -19,26 +19,53 @@

 import os



Don't need this blank line.

QuLogic · 2018-08-09T21:44:09Z

docs/make_projection.py

@@ -19,26 +19,53 @@

 import os

+import inspect
+


Also unnecessary blank line.

QuLogic · 2018-08-09T21:50:15Z

docs/make_projection.py

+
+def plate_carree_plot(i, nplots, fig):
+    central_longitude = 0 if i == 1 else 180
+    ax = fig.add_subplot(1, nplots-1, i,


This -1 is confusing; you should +1 on the i instead.

QuLogic · 2018-08-09T21:50:47Z

docs/make_projection.py


-\n""".format(width=width, proj_constructor=instance_creation_code,
-             coastline_resolution=COASTLINE_RESOLUTION.get(prj, '110m'))
+            """).format(nplots=nplots+1,


And then remove this +1.

QuLogic · 2018-08-09T21:58:31Z

docs/source/crs/projections.rst

@@ -67,7 +62,7 @@ AzimuthalEquidistant

    plt.figure(figsize=(3, 3))
    ax = plt.axes(projection=ccrs.AzimuthalEquidistant(
-        central_latitude=90))
+                             central_latitude=90))


There's too much indent to this now.

…ne removal

kaedonkers · 2018-08-10T17:39:26Z

Good point about the width @QuLogic. I've returned PlateCarree to being vertically stacked.
The UTM projection is now the widest figure (figsize=(10, 3)), but this is only marginally more than the previous widest projection LambertCylindrical (figsize=(9.4248, 3)).
If the width of the UTM projection is still too much I could shave it down to 9.5.

kaedonkers · 2018-09-24T13:23:35Z

@pelson @QuLogic Does this look ready to merge?

QuLogic · 2018-09-27T05:23:19Z

I was going to suggest fig.subplots_adjust(wspace=0), but that doesn't seem to have any effect at the figure size/dpi that would fit in the docs.

QuLogic · 2018-09-27T05:26:20Z

Closes issue #956.

I'm not sure how this is related since this PR is just documentation, so I haven't closed that issue yet.

kaedonkers · 2018-09-27T13:17:35Z

Thanks @QuLogic!

Oops, right you are. It closes #986, not #956. I'll go ahead and close the correct issue.

Kevin Donkers added 6 commits August 8, 2018 16:10

Testing with two UTM zones defined in SPECIAL_CASES

6bdfb44

Add exception to make_projection.py to create plot of subplots of eac…

aa4dc0b

…h UTM zone

Testing with two UTM zones defined in SPECIAL_CASES

3fdf4fc

Add exception to make_projection.py to create plot of subplots of eac…

689b08b

…h UTM zone

make_projection.py now makes single plots of subplots

c50c533

Code for multiple plots now gleaned from methods

9bc0b67

stickler-ci reviewed Aug 9, 2018

View reviewed changes

Kevin Donkers added 2 commits August 9, 2018 09:20

PEP8 stickling

6db6473

Update license header date

7156748

stickler-ci reviewed Aug 9, 2018

View reviewed changes

Remove whitespace from blank lines

07af784

stickler-ci reviewed Aug 9, 2018

View reviewed changes

Pass fig argument to subplotting routine

d739ee8

QuLogic reviewed Aug 9, 2018

View reviewed changes

Kevin Donkers added 4 commits August 10, 2018 17:32

More Pythonic indexing in subplotting routines + whitespace and newli…

3ab0bc1

…ne removal

Correct indenting

31223bd

Rewrite multiplot code to specify figsize for each case

73260f3

Replace missing join function

dfa7af5

QuLogic approved these changes Sep 27, 2018

View reviewed changes

QuLogic merged commit e9df849 into SciTools:master Sep 27, 2018

QuLogic added this to the 0.17 milestone Sep 27, 2018

QuLogic added the Type: Documentation label Sep 27, 2018

kaedonkers deleted the utm-projection branch September 27, 2018 13:17

kaedonkers mentioned this pull request Sep 27, 2018

Display all 60 zones of UTM projection in projection list #986

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all 60 zones of the UTM projection to the docs projection list #1103

Add all 60 zones of the UTM projection to the docs projection list #1103

kaedonkers commented Aug 9, 2018 •

edited

Loading

kaedonkers commented Aug 9, 2018

stickler-ci Aug 9, 2018

kaedonkers Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

stickler-ci Aug 9, 2018

QuLogic left a comment

QuLogic Aug 9, 2018

QuLogic Aug 9, 2018

QuLogic Aug 9, 2018

QuLogic Aug 9, 2018

QuLogic Aug 9, 2018

kaedonkers commented Aug 10, 2018 •

edited

Loading

kaedonkers commented Sep 24, 2018

QuLogic commented Sep 27, 2018

QuLogic commented Sep 27, 2018

kaedonkers commented Sep 27, 2018



		def utm_plot(i, nplots):
		ax = fig.add_subplot(1, nplots-1, i,

Add all 60 zones of the UTM projection to the docs projection list #1103

Add all 60 zones of the UTM projection to the docs projection list #1103

Conversation

kaedonkers commented Aug 9, 2018 • edited Loading

Rationale

Implications

kaedonkers commented Aug 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

QuLogic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kaedonkers commented Aug 10, 2018 • edited Loading

kaedonkers commented Sep 24, 2018

QuLogic commented Sep 27, 2018

QuLogic commented Sep 27, 2018

kaedonkers commented Sep 27, 2018

kaedonkers commented Aug 9, 2018 •

edited

Loading

kaedonkers commented Aug 10, 2018 •

edited

Loading