TST: Fix license checks with new git and Python. #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New git-log does not accept empty strings for paths; we did not need to pass an empty string since it was just an artifact of the parsing. Use NUL-termination instead of newlines as this prevents git from adding any additional porcelain to the filenames. Also, use a raw-string for regexes to avoid invalid escapes.
dopplershift
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New git-log does not accept empty strings for paths; we did not need to pass an empty string since it was just an artifact of the parsing. Use NUL-termination instead of newlines as this prevents git from adding any additional porcelain to the filenames.
Also, use a raw-string for regexes to avoid invalid escapes.