BLD: Add pyproject.toml defining build requirements. #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
approved these changes
Sep 27, 2018
ajdawson
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
This looks good to me, provided that the source distribution is built using an up-to-date version of setuptools. If an older version is used (I tried 40.0.0) then the pyproject.toml file is not automatically included in the source distribution and has to be added to MANIFEST.in. I don't know if it is worth being explicit about this or not.
|
Hmm, might as well; I've added it in. |
dopplershift
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the new PEP518 metadata to get Cython and NumPy installed prior to building.
Fixes #1112.
See also #1035.