Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor typos and style issues #1137

Merged
merged 4 commits into from
Oct 1, 2018
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Oct 1, 2018

Just a few things found with codespell.

@QuLogic QuLogic changed the title Fix some minor typos. Fix some minor typos and style issues Oct 1, 2018
@QuLogic
Copy link
Member Author

QuLogic commented Oct 1, 2018

Also fixed a few flake8 things and some invalid escape sequences.

@ajdawson
Copy link
Member

ajdawson commented Oct 1, 2018

Should the changes to versioneer.py and _version.py be made in versioneer itself and a new version deployed for cartopy? The changes you made are small so I don't mind changing the generated files in this case, but it might not be a sustainable path.

@QuLogic
Copy link
Member Author

QuLogic commented Oct 1, 2018

I tried re-generating from the latest versioneer, but the version we have is already a patched one from @pelson, so it makes for a much larger change, and doesn't support the version scheme we currently have set.

@ajdawson
Copy link
Member

ajdawson commented Oct 1, 2018

I tried re-generating from the latest versioneer, but the version we have is already a patched one from @pelson, so it makes for a much larger change, and doesn't support the version scheme we currently have set.

Something for another time then.

@ajdawson ajdawson merged commit b3508a1 into SciTools:master Oct 1, 2018
@QuLogic QuLogic deleted the spell branch October 1, 2018 19:30
@QuLogic QuLogic added this to the 0.17 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants