Add raster caching to smooth pan/zoom #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since I've only put this up as a reviewer of the larger #1192, I'm happy to merge this myself. |
Closed
QuLogic
reviewed
Nov 16, 2018
|
|
||
| def on_press(self, event=None): | ||
| self.user_is_interacting = True | ||
| self.stale = True |
There was a problem hiding this comment.
Why does a mousedown trigger a redraw?
There was a problem hiding this comment.
You know, that is a fine question that I didn't think to ask.
I can't see any benefit to it either.
pelson
added a commit
to pelson/cartopy
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Allow SlippyImageArtist to cache images to be re-drawn while interacting with the figure.
This makes slow rendering images (such as those going to the net, or images that need reprojecting) not lock up the interactivity of pan/zoom and to only trigger the re-fetch once we have finished interacting.
Note: Implementation from @kaedonkers. I've just lifted a commit from #1192 (@dkillick's PR).
Implications
Adds a cache to SlippyImageArtist that is invalidated each full redraw request.