Merge pull request #2393 from rcomer/gl-titles

FIX: ensure Gridliner is up-to-date for title adjustment

lib/cartopy/mpl/geoaxes.py

@@ -538,8 +538,10 @@ def _update_title_position(self, renderer):
         # Get the max ymax of all top labels
         top = -1
         for gl in gridliners:
-            if gl.has_labels():
-                # Both top and geo labels can appear at the top of the axes
+            # Both top and geo labels can appear at the top of the axes
+            if gl.top_labels or gl.geo_labels:
+                # Make sure Gridliner is populated and up-to-date
+                gl._draw_gridliner(renderer=renderer)
                 for label in (gl.top_label_artists +
                               gl.geo_label_artists):
                     bb = label.get_tightbbox(renderer)

lib/cartopy/tests/mpl/test_gridliner.py

@@ -561,6 +561,20 @@ def test_gridliner_title_noadjust():
     assert ax.title.get_position() == pos
 
 
+def test_gridliner_title_adjust_no_layout_engine():
+    fig = plt.figure()
+    ax = fig.add_subplot(projection=ccrs.PlateCarree())
+    gl = ax.gridlines(draw_labels=True)
+    title = ax.set_title("MY TITLE")
+
+    # After first draw, title should be above top labels.
+    fig.draw_without_rendering()
+    max_label_y = max([bb.get_tightbbox().ymax for bb in gl.top_label_artists])
+    min_title_y = title.get_tightbbox().ymin
+
+    assert min_title_y > max_label_y
+
+
 def test_gridliner_labels_zoom():
     fig = plt.figure()
     ax = fig.add_subplot(1, 1, 1, projection=ccrs.PlateCarree())