Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire site.cfg #3462

Open
pp-mo opened this issue Oct 14, 2019 · 7 comments
Open

Retire site.cfg #3462

pp-mo opened this issue Oct 14, 2019 · 7 comments

Comments

@pp-mo
Copy link
Member

pp-mo commented Oct 14, 2019

Ref: #3458

This is less and less used, and an awkward and old-fashioned approach for users (IMHO).
It now contains just 3 path settings :

  • iris-sample-data can be configured by PYTHONPATH instead as it is importable (which is already a supported option).
  • iris-test-data could be made importable
  • the dot-path remains. Perhaps this can be fixed some other way.
    • frankly this is a really ancient and little-used feature which we probably don't need at all IMHO. But this isn't the time to address that
@bjlittle
Copy link
Member

bjlittle commented Oct 14, 2019

@pp-mo I'm 👍 for tidying the setup.cfg but I'm 👎 on flat out retiring it.... unless you've (we've) got a clear approach to do this. Any further thoughts? 🤔

I really don't believe it makes sense to make iris-test-data importable. It just a big old data blob, and what's more it's only for developers. I'd say that making it importable is not really worth the effort. I think it's just about okay for iris-sample-data to be importable, as long as it doesn't bloat too much further - if it did, then I think that we'd need to seriously reconsider whether it should be importable or not.

@pp-mo
Copy link
Member Author

pp-mo commented Oct 14, 2019

@bjlittle I really don't believe it makes sense to make iris-test-data importable. It just a big old data blob, and what's more it's only for developers.

ok, maybe it's not needed if we believe in #3416.
But in that case we really need some more help for aspiring developers -- I'll make more comment there..

@bjlittle bjlittle added this to To do in Technical Debt Jun 1, 2020
@bjlittle bjlittle added the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label Nov 25, 2020
@bjlittle bjlittle self-assigned this Nov 25, 2020
@bjlittle
Copy link
Member

Action on @bjlittle to make a proposal on how to move forwards and rationalise site.cfg et al at the peloton e.g., use of DOCS_DIR

@pp-mo
Copy link
Member Author

pp-mo commented Nov 25, 2020

Also found we have another setting "Resources/doc_dir "that is still used
in this line
Though it's not mentioned in site.cfg.template

@rcomer rcomer added this to Backlog in Peloton via automation Aug 25, 2021
@trexfeathers
Copy link
Contributor

Offline discussion: we all share the ambition!

@bjlittle bjlittle removed the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label Feb 22, 2023
@bjlittle
Copy link
Member

bjlittle commented Feb 22, 2023

Given https://peps.python.org/pep-0621/, we can now migrate and retire the setup.cfg into the pyproject.toml 👍

@pp-mo
Copy link
Member Author

pp-mo commented Feb 23, 2023

Given https://peps.python.org/pep-0621/, we can now migrate and retire the setup.cfg into the pyproject.toml 👍

I don't think this is the same thing at all.
This issue is about the site.cfg file (example)
Which the user has to fill in for themselves, after installing, and I still don't think this settings file should be needed at all, really.

So it's really not about packaging, or installing : not done in setup.py/setup.cfg/pyproject.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Peloton
Backlog
Technical Debt
  
To do
Status: No status
Development

No branches or pull requests

3 participants