Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection for range=modulus and bounds aligned with negative minimum #4278

Merged
merged 3 commits into from Sep 22, 2021

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Aug 10, 2021

🚀 Pull Request

Description

Fixes #4221, in precisely the way suggested there.


Consult Iris pull request check list

@trexfeathers trexfeathers added the Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton label Aug 11, 2021
@rcomer rcomer added this to Backlog in Peloton via automation Aug 25, 2021
Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good to me. Thanks @rcomer !

@lbdreyer lbdreyer merged commit d2652aa into SciTools:main Sep 22, 2021
Peloton automation moved this from Backlog to Done Sep 22, 2021
@rcomer
Copy link
Member Author

rcomer commented Sep 22, 2021

Thanks @lbdreyer! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Peloton 🚴‍♂️ Target a breakaway issue to be caught and closed by the peloton Type: Bug
Projects
Development

Successfully merging this pull request may close these issues.

Intersection bounds when requested minimum is negative
3 participants