Refactor some netcdf save code #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
changed the title
|
Re-opened, and merged from new update 'mesh-data-model'. |
pp-mo
force-pushed
the
ugrid_save_preliminary
branch
from
f8a328a
to
69fd94e
Compare
bjlittle
reviewed
Sep 21, 2021
bjlittle
reviewed
Sep 21, 2021
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
pp-mo
force-pushed
the
ugrid_save_preliminary
branch
from
24040d4
to
03d1bf8
Compare
|
Rebased onto 'main', |
bjlittle
approved these changes
Sep 21, 2021
|
馃暫 馃殌 馃尀 Thanks for sticking with it @bjlittle |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Sep 22, 2021
* main: (94 commits) added support for make html-noapi and html-quick for the docs build (SciTools#4333) Refactor some netcdf save code (SciTools#4301) [pre-commit.ci] pre-commit autoupdate (SciTools#4329) Update to loading docs to cover absence of 'or' for constraints (SciTools#4321) update latest.rst.template (SciTools#4323) stable cartopy feature download (SciTools#4328) Skip TestConstrainedLoad if data missing (SciTools#4319) Add 'Good First Issue' label to reasons an issue doesn't go stale (SciTools#4317) Gallery: simplify quiver example (SciTools#4120) Improve styling in a minor way in docs (SciTools#4314) bump version (SciTools#4310) Made clear we only test on Linux. (SciTools#4309) Updated environment lockfiles (SciTools#4308) Include Discussions in Getting Involved. (SciTools#4307) Fixed text to show as link. (SciTools#4305) [pre-commit.ci] pre-commit autoupdate (SciTools#4299) Updated environment lockfiles (SciTools#4298) cartopy feature download (SciTools#4304) Mesh Loading (AVD-1813) (SciTools#4262) reset whatsnew latest (SciTools#4288) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 Pull Request
Description
Initial "tidying" to routines in
netcdf.py, to prepare for the addition of UGRID saving support.This unifies the handling codepaths for different types of cube components,
to make it easier to add the new ones which are coming (mesh-element coords and connectivities).
This is a pure refactor : by design, should not change any exisiting behaviour/results.
These same code changes have been proven against extra CDL test snapshots in #4297
.. but we don't ever intend to merge that extra testing, as it is excessive and somewhat incomplete/unpolished
Consult Iris pull request check list