Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pandas_ndim FUTURE flag #4909

Merged
merged 2 commits into from Oct 24, 2022

Conversation

trexfeathers
Copy link
Contributor

馃殌 Pull Request

Description

In preparation for breaking changes to be made to iris.pandas.as_dataframe() and iris.pandas.as_series() - #4669.

QUESTION: how should future flags be documented? The existing datum_support flag is not documented but that might just be an oversight?


Consult Iris pull request check list

@trexfeathers trexfeathers changed the title Added pandas_ndim FUTURE flag. Added pandas_ndim FUTURE flag Aug 17, 2022
@rcomer
Copy link
Member

rcomer commented Aug 17, 2022

how should future flags be documented?

Example from Ye Olden Dayes
https://scitools.org.uk/iris/docs/v1.13.0/iris/iris.html?highlight=future#iris.Future

@trexfeathers trexfeathers deleted the branch SciTools:pandas_ndim September 2, 2022 17:19
@trexfeathers trexfeathers reopened this Sep 2, 2022
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stephenworsley stephenworsley merged commit 3234489 into SciTools:pandas_ndim Oct 24, 2022
@trexfeathers trexfeathers deleted the pandas_future branch November 29, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants