Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid realising auxiliary coordinates in concatenate #5142

Merged
merged 9 commits into from Jun 15, 2023

Conversation

sloosvel
Copy link
Contributor

🚀 Pull Request

Description


This PR changes the call from coord.points and coord.bounds to coord.core_points() and coord.core_bounds() respectively in order to avoid realising auxiliary coordinates when concatenating cubes.

Closes #5115

Consult Iris pull request check list

@sloosvel sloosvel marked this pull request as draft January 30, 2023 17:43
@bouweandela
Copy link
Member

@trexfeathers So far this pull request hasn't received much attention, but it is a useful feature for the ESMValTool community. Would it help to speed things up if I helped with reviewing it?

@sloosvel sloosvel changed the base branch from main to v3.6.x June 14, 2023 15:32
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0937e4f) 89.31% compared to head (8adfbf3) 89.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.6.x    #5142   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files          89       89           
  Lines       22485    22392   -93     
  Branches     5409     5375   -34     
=======================================
- Hits        20083    20002   -81     
+ Misses       1648     1640    -8     
+ Partials      754      750    -4     
Impacted Files Coverage Δ
lib/iris/_concatenate.py 95.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bjlittle bjlittle self-assigned this Jun 15, 2023
@bjlittle bjlittle self-requested a review June 15, 2023 13:01
@bjlittle
Copy link
Member

@sloosvel Just spinning up on the review for this now ...

Also, don't worry about the CI linkcheck failure 👍

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloosvel Okay... this PR has been a long time coming! Thanks for hanging in there.

I'm happy to merge this PR as-is 👍

The v3.6.x branch already has a fix for the linkcheck failure, so rather than ask you to cherry-pick that commit from main, I'm happy to merge with this CI failure.

Also, post merge I'll create a PR on v3.6.x with a whatsnew entry to cover this PR. I'll ping you on that PR so that you can eyeball and sign-off the whatsnew patch entry.

Thanks again 🍻

@bjlittle bjlittle merged commit 438f292 into SciTools:v3.6.x Jun 15, 2023
16 of 17 checks passed
bjlittle added a commit to bjlittle/iris that referenced this pull request Jun 15, 2023
@bjlittle bjlittle mentioned this pull request Jun 15, 2023
@sloosvel
Copy link
Contributor Author

Many thanks!!

trexfeathers added a commit that referenced this pull request Jun 16, 2023
Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done - v3.6.1
Development

Successfully merging this pull request may close these issues.

Concatenating cubes realises auxiliary coordinates.
5 participants