New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid realising auxiliary coordinates in concatenate
#5142
Conversation
@trexfeathers So far this pull request hasn't received much attention, but it is a useful feature for the ESMValTool community. Would it help to speed things up if I helped with reviewing it? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3.6.x #5142 +/- ##
=======================================
Coverage 89.31% 89.32%
=======================================
Files 89 89
Lines 22485 22392 -93
Branches 5409 5375 -34
=======================================
- Hits 20083 20002 -81
+ Misses 1648 1640 -8
+ Partials 754 750 -4
☔ View full report in Codecov by Sentry. |
@sloosvel Just spinning up on the review for this now ... Also, don't worry about the CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sloosvel Okay... this PR has been a long time coming! Thanks for hanging in there.
I'm happy to merge this PR as-is 👍
The v3.6.x
branch already has a fix for the linkcheck
failure, so rather than ask you to cherry-pick that commit from main
, I'm happy to merge with this CI failure.
Also, post merge I'll create a PR on v3.6.x
with a whatsnew
entry to cover this PR. I'll ping you on that PR so that you can eyeball and sign-off the whatsnew
patch entry.
Thanks again 🍻
Many thanks!! |
🚀 Pull Request
Description
This PR changes the call from
coord.points
andcoord.bounds
tocoord.core_points()
andcoord.core_bounds()
respectively in order to avoid realising auxiliary coordinates when concatenating cubes.Closes #5115
Consult Iris pull request check list