Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark runner script #5215

Merged
merged 18 commits into from Mar 31, 2023
Merged

Benchmark runner script #5215

merged 18 commits into from Mar 31, 2023

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Mar 27, 2023

🚀 Pull Request

Description

Moves benchmark convenience scripts from noxfile.py into a dedicated bm_runner.py.

  • Better suited to providing user help information.
  • Runner only uses built-in dependencies.
  • Agnostic to Nox/Tox/some-other-future-architecture.

Needed before #5184 can be completed.

This also introduces a low-overhead way of keeping the listed Python versions aligned in the various files - see test_coding_standards.test_python_versions().


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (512ca75) 89.27% compared to head (d2c8c79) 89.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5215   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files          88       88           
  Lines       22258    22258           
  Branches     4867     4867           
=======================================
  Hits        19871    19871           
  Misses       1641     1641           
  Partials      746      746           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lbdreyer lbdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good I just have a few, hopefully minor, comments.

Regarding the new test_python_versions in test_coding_standards.py, I can see the benefit of it as we will no doubt trip ourselves up over this in future. I have some reservations about the implementation as it is very dependent on the formating of the specified files, but I assume we won't be modifying those files that often, so it shouldn't be such a regular issue. In an ideal world we would have one location we keep the supported python versions and then all these specialised config files would refer to that, but that is likely very complex (or impossible) to implement. So I'm happy to go with what we have right now, and then we can always change it in future

benchmarks/README.md Outdated Show resolved Hide resolved
lib/iris/tests/test_coding_standards.py Show resolved Hide resolved
benchmarks/bm_runner.py Show resolved Hide resolved
benchmarks/bm_runner.py Outdated Show resolved Hide resolved
benchmarks/bm_runner.py Outdated Show resolved Hide resolved
benchmarks/bm_runner.py Show resolved Hide resolved
@lbdreyer lbdreyer merged commit b8f5eea into SciTools:main Mar 31, 2023
15 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @lbdreyer!

HGWright added a commit to HGWright/iris that referenced this pull request Apr 3, 2023
* 'main' of github.com:SciTools/iris:
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
tkknight added a commit to tkknight/iris that referenced this pull request Apr 4, 2023
* upstream/main: (274 commits)
  Cf cell method (SciTools#5224)
  Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5230)
  Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227)
  raise dask min pin (SciTools#5225)
  Enable lazy computation of wind vector rotation (SciTools#4972)
  Benchmark runner script (SciTools#5215)
  add locks readme (SciTools#5222)
  use explicit version for ci refresh-lockfiles gha (SciTools#5221)
  SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220)
  Fix Makefile for consequences of SciTools#5204. (SciTools#5217)
  Bump actions/stale from 7 to 8 (SciTools#5208)
  Remove Iris' TestRunner (SciTools#5205)
  standardize requirements structure (SciTools#5204)
  Updated environment lockfiles (SciTools#5199)
  Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189)
  Updated environment lockfiles (SciTools#5192)
  announce new contributor in whatsnew (SciTools#5198)
  iris.util.new_axis anonymous new dimension fix (SciTools#5194)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants