Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing numpy legacy printing with array2string and remaking result… #5235

Merged
merged 5 commits into from Apr 4, 2023

Conversation

HGWright
Copy link
Contributor

@HGWright HGWright commented Apr 4, 2023

…s for dependent tests

🚀 Pull Request

Description

Replaced the use of a legacy pin for numpy array printing with array2string. This initially caused just under 500 tests to fail and so the files containing the expected results for these tests have been replaced.

closes #3048

missing whatsnew entry will remove from draft once added


Consult Iris pull request check list

@HGWright HGWright requested a review from bjlittle April 4, 2023 13:46
@HGWright HGWright marked this pull request as ready for review April 4, 2023 13:46
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6b25c3a) 89.28% compared to head (ed35d4f) 89.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5235      +/-   ##
==========================================
- Coverage   89.28%   89.27%   -0.01%     
==========================================
  Files          88       88              
  Lines       22269    22261       -8     
  Branches     4870     4873       +3     
==========================================
- Hits        19882    19874       -8     
  Misses       1641     1641              
  Partials      746      746              

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pp-mo
Copy link
Member

pp-mo commented Apr 4, 2023

1f42856 Nice @HGWright
I may steal that !

@HGWright
Copy link
Contributor Author

HGWright commented Apr 4, 2023

@pp-mo its all @bjlittle on that one!

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright This is great, thanks for making this happen!

The format of the CML isn't user facing, and dev's hardly ever look at the CML, so I'm not precious about tabbing indents as previous (simply because I know you'd have to go off-piste to make that happen) and I'm keen that we adopt the sane defaults of numpy with minimal custiomisation i.e., only do that for a good reason and by exception.

So this all good good to me. Just a minor comment to service on the whatsnew entry, and I know the codecov.yml and .git-blame-ignore-revs are in-bound.

docs/src/whatsnew/latest.rst Outdated Show resolved Hide resolved
codecov.yml Show resolved Hide resolved
@bjlittle bjlittle merged commit 333a3a9 into SciTools:main Apr 4, 2023
16 checks passed
pp-mo pushed a commit to SciTools/iris-grib that referenced this pull request Jul 6, 2023
* NEP 29 changes - py3.9/10/11
* Updated CML files, from SciTools/iris#5235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unpin numpy legacy printing
3 participants