New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing numpy legacy printing with array2string and remaking result… #5235
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5235 +/- ##
==========================================
- Coverage 89.28% 89.27% -0.01%
==========================================
Files 88 88
Lines 22269 22261 -8
Branches 4870 4873 +3
==========================================
- Hits 19882 19874 -8
Misses 1641 1641
Partials 746 746 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HGWright This is great, thanks for making this happen!
The format of the CML isn't user facing, and dev's hardly ever look at the CML, so I'm not precious about tabbing indents as previous (simply because I know you'd have to go off-piste to make that happen) and I'm keen that we adopt the sane defaults of numpy
with minimal custiomisation i.e., only do that for a good reason and by exception.
So this all good good to me. Just a minor comment to service on the whatsnew
entry, and I know the codecov.yml
and .git-blame-ignore-revs
are in-bound.
* NEP 29 changes - py3.9/10/11 * Updated CML files, from SciTools/iris#5235
…s for dependent tests
🚀 Pull Request
Description
Replaced the use of a legacy pin for numpy array printing with array2string. This initially caused just under 500 tests to fail and so the files containing the expected results for these tests have been replaced.
closes #3048
missing whatsnew entry will remove from draft once added
Consult Iris pull request check list