Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5347 #5349

Merged
merged 4 commits into from Jun 15, 2023
Merged

Fix #5347 #5349

merged 4 commits into from Jun 15, 2023

Conversation

stephenworsley
Copy link
Contributor

🚀 Pull Request

Description

Fixes #5347.


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0937e4f) 89.31% compared to head (cea9a18) 89.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.6.x    #5349   +/-   ##
=======================================
  Coverage   89.31%   89.32%           
=======================================
  Files          89       89           
  Lines       22485    22393   -92     
  Branches     5409     5375   -34     
=======================================
- Hits        20083    20003   -80     
+ Misses       1648     1640    -8     
+ Partials      754      750    -4     
Impacted Files Coverage Δ
lib/iris/cube.py 90.57% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bjlittle
Copy link
Member

@stephenworsley Awesome 👍

Could you please target the v3.6.x release feature branch instead. Looks like we're going to be making an iris v3.6.1 release soon, and it makes sense for this fix to be available to the community ASAP.

Thanks 🍻

@stephenworsley stephenworsley changed the base branch from main to v3.6.x June 15, 2023 08:14
@bjlittle
Copy link
Member

@stephenworsley I've pushed a PR to your fork to add a patch whatsnew entry, see stephenworsley#9

@bjlittle bjlittle self-requested a review June 15, 2023 13:29
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephenworsley Awesome. Lovely fix 👍

@bjlittle bjlittle self-assigned this Jun 15, 2023
@bjlittle bjlittle merged commit eaa7ee4 into SciTools:v3.6.x Jun 15, 2023
17 checks passed
@valeriupredoi
Copy link

very many thanks @stephenworsley and @bjlittle 🍺 x2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done - v3.6.1
Development

Successfully merging this pull request may close these issues.

Multiplying and converting units does not work with Dask distributed
3 participants