Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn via issue if overnight benchmarks fail #5432

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Warn via issue if overnight benchmarks fail #5432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfe2cbe
Include a warning step for overnight benchmarking.
trexfeathers Aug 17, 2023
183af8d
Fix for failure warning script.
trexfeathers Aug 17, 2023
e865c66
Better formatting of warning issue title.
trexfeathers Aug 17, 2023
fd72f5b
What's new entry.
trexfeathers Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/benchmarks_run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ jobs:
python benchmarks/bm_runner.py branch origin/${{ github.base_ref }}

- name: Run overnight benchmarks
id: overnight
if: ${{ github.event_name != 'pull_request' }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -99,6 +100,17 @@ jobs:
python benchmarks/bm_runner.py overnight $first_commit
fi

- name: Warn of failure
if: >
failure() &&
steps.overnight.outcome == 'failure'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
title="Overnight benchmark workflow failed: \`${{ github.run_id }}\`"
body="Generated by GHA run [\`${{github.run_id}}\`](https://github.com/${{github.repository}}/actions/runs/${{github.run_id}})"
gh issue create --title "$title" --body "$body" --label "Bot" --label "Type: Performance" --repo $GITHUB_REPOSITORY

- name: Upload any benchmark reports
uses: actions/upload-artifact@v3
with:
Expand Down
4 changes: 4 additions & 0 deletions docs/src/whatsnew/latest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ This document explains the changes made to Iris for this release
of how the pull request changes affect performance. (feature branch:
:pull:`5431`)

#. `@trexfeathers`_ added a catch to the overnight benchmark workflow to raise
an issue if the overnight run fails - this was previously an 'invisible'
problem. (feature branch: :pull:`5432`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand Down