Remove uses of logging.warn #5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5488 +/- ##
=======================================
Coverage 89.37% 89.37%
=======================================
Files 89 89
Lines 22444 22446 +2
Branches 5381 5387 +6
=======================================
+ Hits 20059 20061 +2
Misses 1639 1639
Partials 746 746
☔ View full report in Codecov by Sentry. |
HGWright
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Looks great @trexfeathers! Happy to merge, looking forward to all the warning improvements coming soon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
The development team has decided to embrace Python warnings, rather than Python logging, as the solution to user warnings.
Needed by #5472 - can't categorise warnings if they aren't warnings yet!
Consult Iris pull request check list