Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell fixes #5546

Merged

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Oct 18, 2023

πŸš€ Pull Request

Description

Note that, this pull-request is targeting the SciTools:pre-commit-ci-update-config branch (base branch of #5527)

#5527 is failing due to a pre-commit.ci update in codespell version (github.com/codespell-project/codespell: v2.2.5 β†’ v2.2.6), which now catches legitimate spelling corrections.

This pull-request addresses the typos identified by codespell.

i.e., see here

image


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests βœ…

Comparison is base (8230943) 0.00% compared to head (04165e8) 89.41%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           pre-commit-ci-update-config    #5546       +/-   ##
================================================================
+ Coverage                             0   89.41%   +89.41%     
================================================================
  Files                                0       89       +89     
  Lines                                0    22539    +22539     
  Branches                             0     5387     +5387     
================================================================
+ Hits                                 0    20154    +20154     
- Misses                               0     1639     +1639     
- Partials                             0      746      +746     
Files Coverage Ξ”
lib/iris/_deprecation.py 72.72% <ΓΈ> (ΓΈ)
lib/iris/analysis/trajectory.py 94.44% <ΓΈ> (ΓΈ)
lib/iris/fileformats/netcdf/saver.py 89.14% <ΓΈ> (ΓΈ)
lib/iris/pandas.py 95.16% <ΓΈ> (ΓΈ)

... and 85 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@bjlittle bjlittle marked this pull request as ready for review October 18, 2023 13:00
@trexfeathers
Copy link
Contributor

I'm gonna fail so many pre-commit checks in future; I love hyphens πŸ˜‚

But I've always said I would prefer a rule I don't like rather than a free-for-all πŸ‘

@trexfeathers trexfeathers merged commit a5a4e2c into SciTools:pre-commit-ci-update-config Oct 18, 2023
17 checks passed
trexfeathers pushed a commit that referenced this pull request Oct 18, 2023
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 β†’ v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/codespell-project/codespell: v2.2.5 β†’ v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6)

* codespell fixes (#5546)

* codespell fixes

* add whatsnew entry

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Bill Little <bill.james.little@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants