Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocated the Technical Papers documentation to Further Topics. #5602

Merged
merged 8 commits into from Dec 1, 2023

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Nov 24, 2023

🚀 Pull Request

Relocated the Technical Papers documentation to Further Topics.

Relevant #4990

4990 suggests removing the Technical Papers heading in general, which I have not done, but could do.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (507c34c) 89.68% compared to head (c645e49) 89.68%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5602   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          90       90           
  Lines       22815    22815           
  Branches     5445     5445           
=======================================
  Hits        20462    20462           
  Misses       1619     1619           
  Partials      734      734           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member

pp-mo commented Nov 24, 2023

Hi @ESadek-MO I see this is pretty close.

The way you fixed the failure is interesting ..

I was rather expecting that the "Further topics" and "Tech papers" would just become one long list.
But if we did do that, there would no longer be anything for that link to point at. See #5603

But I think all those objections require more thinking + decisions, a bit of a debate.
So I don't think it's worth trying to resolve any of it here, and we may as well merge this as it currently done.

@ESadek-MO ESadek-MO marked this pull request as draft November 24, 2023 14:54
@ESadek-MO
Copy link
Contributor Author

Converted to draft so it doesn't get confused with #5604.

@ESadek-MO ESadek-MO marked this pull request as ready for review November 30, 2023 13:44
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ESadek-MO

I think this looks great now.
A lot less fussy, and generally more visible to users.

@pp-mo pp-mo merged commit 54ad9be into SciTools:main Dec 1, 2023
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Dec 4, 2023
* 'numpydocs1' of github.com:tkknight/iris:
  Feedstock rc branch management in do-nothing script (SciTools#5515)
  Relocated the Technical Papers documentation to Further Topics.  (SciTools#5602)
  Fix pp save of realization coordinate (SciTools#5568)
  Bump actions/checkout from 3 to 4 (SciTools#5460)
  Bump actions/github-script from 6 to 7 (SciTools#5580)
  Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607)
  CI: specify matplotlib-base (SciTools#5606)
tkknight added a commit to tkknight/iris that referenced this pull request Dec 6, 2023
* main:
  DOCS: Numpydocs1 (SciTools#5578)
  add links to scitools-classroom repo. (SciTools#5609)
  Feedstock rc branch management in do-nothing script (SciTools#5515)
  Relocated the Technical Papers documentation to Further Topics.  (SciTools#5602)
  Fix pp save of realization coordinate (SciTools#5568)
  Bump actions/checkout from 3 to 4 (SciTools#5460)
  Bump actions/github-script from 6 to 7 (SciTools#5580)
  Bump conda-incubator/setup-miniconda from 2 to 3 (SciTools#5607)
  CI: specify matplotlib-base (SciTools#5606)
  Mergeback of `FEATURE_chunk_control` branch (SciTools#5588)
  [CI Bot] environment lockfiles auto-update (SciTools#5547)
  Mergeback of "Feature _split_attrs" branch (SciTools#5152)
  add whatsnew (SciTools#5596)
  Refactor area weighted regridding, improve performance (SciTools#5543)
  Allowing exemption to axis guessing on coords (SciTools#5551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants