Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make further topics obviously different #5684

Merged
merged 4 commits into from Jan 10, 2024

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jan 9, 2024

🚀 Pull Request

Description

A very simple way to make it obvious in a TOC-tree that Further Topics is not just a page, but a subsection of its own.

I chose to edit the title itself, rather than an alias in the existing TOC-tree, so that this will also apply if included in other TOC-trees. I also kinda like the title being this way 😁


Consult Iris pull request check list

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bfaebd) 89.69% compared to head (bcdc288) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5684   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22809    22809           
  Branches     5441     5441           
=======================================
  Hits        20458    20458           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO ESadek-MO self-assigned this Jan 10, 2024
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should apply this to all nested toc-members? I found the below all expand out when clicked:

  • Dask Best Practices
  • Mesh Support
  • Gallery

I think we should maintain consistency throughout the docs, which'd also mean we'd have to remember the format if creating new nests later down the line (which is a good habit, just thought it was worth noting).

It's a good idea though, and a simple change!

@tkknight
Copy link
Contributor

There maybe an option in the pydata theme to do this. I will check.

@trexfeathers
Copy link
Contributor Author

There maybe an option in the pydata theme to do this. I will check.

There is! I'm just checking the blame for why we turned it off originally...

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Jan 10, 2024

There maybe an option in the pydata theme to do this. I will check.

There is! I'm just checking the blame for why we turned it off originally...

@tkknight looks like this line was introduced when you introduced PyData Theme (#4661). Would you be comfortable with me turning it off?

"collapse_navigation": True,

ref

@tkknight
Copy link
Contributor

Try removing this line and rebuild the docs.

https://github.com/SciTools/iris/blob/main/docs/src/conf.py#L294

@trexfeathers
Copy link
Contributor Author

I like it

image

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this new version. Adds a lot of functionality with a single line of code imo, and doesn't seem to break anything.

Just need to add a whatsnew then I'm happy for this to go!

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super happy with this, thanks @trexfeathers!

@ESadek-MO ESadek-MO merged commit d528fce into SciTools:main Jan 10, 2024
17 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jan 10, 2024
* upstream/main:
  Make further topics obviously different (SciTools#5684)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
  ruff complliance for D100. (SciTools#5678)
  move tests.pp to tests.__init__ (SciTools#5679)
  ruff compliance for D417, D106 (SciTools#5677)
  ruff compliance for D200. (SciTools#5675)
tkknight added a commit to tkknight/iris that referenced this pull request Jan 15, 2024
* upstream/main:
  ruff compliance for D205. (SciTools#5681)
  Added whatsnew to warnings PR (SciTools#5696)
  Removed use of catch_warnings (SciTools#5685)
  Better documentation for Cube names in curl (SciTools#5680)
  fix typo (SciTools#5689)
  Make further topics obviously different (SciTools#5684)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
tkknight added a commit to tkknight/iris that referenced this pull request Jan 24, 2024
* upstream/main: (26 commits)
  Bump scitools/workflows from 2023.12.1 to 2024.01.0 (SciTools#5710)
  Faster trivial equality checks for coordinates and arrays (SciTools#5691)
  Make the Coord.cell method lazy (SciTools#5693)
  Re-write `pearsonr` to use `Resolve` (SciTools#5638)
  ruff compliance for D401. (SciTools#5687)
  Bump actions/cache from 3 to 4 (SciTools#5703)
  update rtd ubuntu and mambaforge (SciTools#5702)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5699)
  ruff compliance for D205. (SciTools#5681)
  Added whatsnew to warnings PR (SciTools#5696)
  Removed use of catch_warnings (SciTools#5685)
  Better documentation for Cube names in curl (SciTools#5680)
  fix typo (SciTools#5689)
  Make further topics obviously different (SciTools#5684)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5682)
  ruff complliance for D100. (SciTools#5678)
  move tests.pp to tests.__init__ (SciTools#5679)
  ruff compliance for D417, D106 (SciTools#5677)
  ruff compliance for D200. (SciTools#5675)
  ruff compliance for D106. (SciTools#5676)
  ...
@trexfeathers trexfeathers deleted the visible_further_topics branch May 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants