Pin ASV - airspeed-velocity/asv#1385 #5756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
Type: Performance
Type: Testing
benchmark_this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5756 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.02%
==========================================
Files 90 91 +1
Lines 22815 22925 +110
Branches 5438 5462 +24
==========================================
+ Hits 20468 20573 +105
- Misses 1617 1620 +3
- Partials 730 732 +2 ☔ View full report in Codecov by Sentry. |
Performance Benchmark Report: b72fe84Performance shiftsFull benchmark resultsGenerated by GHA run |
|
Successful benchmark run demonstrates that this pin is effective |
ESadek-MO
approved these changes
Feb 19, 2024
|
Note that the upstream bug is a bit spurious, and a better fix is to explicitly put the build project command in the asv configuration. |
@HaoZeke thanks, I was looking into that, until I saw that you were investigating including If that doesn't work out then yeah we can add |
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Feb 20, 2024
…umpydoc-pre-commit * 'numpydoc-pre-commit' of github.com:tkknight/iris: Update CF standard names to v84. (SciTools#5761) Regrid docs fix (SciTools#5758) Improve ncdata and CF information on "iris heart xarray" page (SciTools#5752) Pin ASV - airspeed-velocity/asv#1385. (SciTools#5756) Normalise units of coordinate bounds (SciTools#5746) Add "Which Regridder?" Documentation (SciTools#5742) Document `Coord.ignore_axis` (SciTools#5744) Disable navidation with keys for docs HTML theme options (SciTools#5747) Shapefile masking (SciTools#5470) [pre-commit.ci] pre-commit autoupdate (SciTools#5739) DOCS: Add whatsnew for ruff pydocstyle compliance (SciTools#5700) update docstring (SciTools#5737) Updated environment lockfiles (SciTools#5738) Consider NaNs equal when comparing cubes (SciTools#5713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This avoids a bug in Airspeed Velocity's dependencies: airspeed-velocity/asv#1385
Consult Iris pull request check list