Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor warnings from iris.exceptions into iris.warnings #5760

Merged
merged 2 commits into from Feb 20, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Following @bjlittle's suggestion here: #5506 (comment)


Consult Iris pull request check list

@HGWright HGWright self-requested a review February 20, 2024 14:21
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a47fd34) 89.71% compared to head (c2f1f2b) 89.74%.
Report is 18 commits behind head on main.

Files Patch % Lines
lib/iris/fileformats/netcdf/saver.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5760      +/-   ##
==========================================
+ Coverage   89.71%   89.74%   +0.03%     
==========================================
  Files          90       92       +2     
  Lines       22815    22940     +125     
  Branches     5438     5462      +24     
==========================================
+ Hits        20468    20588     +120     
- Misses       1617     1620       +3     
- Partials      730      732       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers trexfeathers changed the title Refactor warnings from iris.exceptions into iris.warnings. Refactor warnings from iris.exceptions into iris.warnings Feb 20, 2024
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, glad we caught this before the release!

@HGWright HGWright merged commit 7859096 into SciTools:main Feb 20, 2024
17 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @HGWright!

tkknight added a commit to tkknight/iris that referenced this pull request Feb 21, 2024
* upstream/main:
  Refactor warnings from `iris.exceptions` into `iris.warnings` (SciTools#5760)
@trexfeathers trexfeathers deleted the refactor_warnings branch May 3, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants