Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure pytest-mock as pytest required-plugin #5815

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented Mar 11, 2024

🚀 Pull Request

Description

This pull-request configures the pytest-mock plugin for pytest, thus making the mocker fixture available.

See https://pytest-mock.readthedocs.io/en/latest/ for further details.

Note that, through the mocker fixture, we have access to vanilla mock module as we know and (un-)love.

image


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (FEATURE_pytest_conversion@80b42f5). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             FEATURE_pytest_conversion    #5815   +/-   ##
============================================================
  Coverage                             ?   89.74%           
============================================================
  Files                                ?       92           
  Lines                                ?    22940           
  Branches                             ?     5462           
============================================================
  Hits                                 ?    20588           
  Misses                               ?     1620           
  Partials                             ?      732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle requested a review from pp-mo March 11, 2024 16:23
@trexfeathers trexfeathers added the Type: Feature Branch Highlight this for a feature branch label Mar 12, 2024
@bjlittle bjlittle removed the request for review from pp-mo March 12, 2024 11:16
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ta @bjlittle

@ESadek-MO ESadek-MO merged commit e954d73 into SciTools:FEATURE_pytest_conversion Mar 12, 2024
21 checks passed
@bjlittle bjlittle deleted the pytest-mock-required-plugins branch March 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants