Better implementation of _shared_utils.results_path() - using PyTest request
#5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trexfeathers
added
Type: Testing
Type: Feature Branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_pytest_conversion #5827 +/- ##
==========================================================
Coverage 89.74% 89.74%
==========================================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
==========================================================
Hits 20588 20588
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
ESadek-MO
requested changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM, thanks @trexfeathers!
Just a small suggestion, but otherwise awesome!
ESadek-MO
merged commit 096b2b3
into
SciTools:FEATURE_pytest_conversion
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was flaky given we could not know where in the call stack the test actually was, and I have no idea how I could have got it working with PyTest parameters - probably something even more flaky.
This version uses publicly available attributes from the PyTest
FixtureRequest, which seems much safer.