pytest migration for unit.common.metadata.test_AncillaryVariableMetadata #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjlittle
added
Type: Feature Branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_pytest_conversion #5854 +/- ##
=============================================================
- Coverage 89.74% 89.74% -0.01%
=============================================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
=============================================================
- Hits 20588 20587 -1
- Misses 1620 1621 +1
Partials 732 732 ☔ View full report in Codecov by Sentry. |
bjlittle
force-pushed
the
pytest-common-metadata-ancillary-variable
branch
from
54c0ade
to
3deb01a
Compare
pp-mo
approved these changes
Mar 19, 2024
| self.cls = AncillaryVariableMetadata | ||
|
|
||
| def test_wraps_docstring(self): | ||
| self.assertEqual(BaseMetadata.__eq__.__doc__, self.cls.__eq__.__doc__) | ||
| assert BaseMetadata.__eq__.__doc__ == self.cls.__eq__.__doc__ |
There was a problem hiding this comment.
I think this check would be less confusing the other way around
| self.cls = AncillaryVariableMetadata | ||
| self.none = self.cls(*(None,) * len(self.cls._fields)) | ||
|
|
||
| def test_wraps_docstring(self): | ||
| self.assertEqual(BaseMetadata.combine.__doc__, self.cls.combine.__doc__) | ||
| assert BaseMetadata.combine.__doc__ == self.cls.combine.__doc__ |
| self.cls = AncillaryVariableMetadata | ||
| self.none = self.cls(*(None,) * len(self.cls._fields)) | ||
|
|
||
| def test_wraps_docstring(self): | ||
| self.assertEqual(BaseMetadata.difference.__doc__, self.cls.difference.__doc__) | ||
| assert BaseMetadata.difference.__doc__ == self.cls.difference.__doc__ |
| self.cls = AncillaryVariableMetadata | ||
| self.none = self.cls(*(None,) * len(self.cls._fields)) | ||
|
|
||
| def test_wraps_docstring(self): | ||
| self.assertEqual(BaseMetadata.equal.__doc__, self.cls.equal.__doc__) | ||
| assert BaseMetadata.equal.__doc__ == self.cls.equal.__doc__ |
bjlittle
force-pushed
the
pytest-common-metadata-ancillary-variable
branch
from
eb21150
to
abfc7ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: