Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest migration for unit.common.metadata.test_BaseMetadata #5868

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (2e18ae8) to head (ed7934b).
Report is 36 commits behind head on FEATURE_pytest_conversion.

❗ Current head ed7934b differs from pull request most recent head 0c6a6dc. Consider uploading reports for the commit 0c6a6dc to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                     @@
##           FEATURE_pytest_conversion    #5868   +/-   ##
==========================================================
  Coverage                      89.74%   89.75%           
==========================================================
  Files                             92       92           
  Lines                          22940    22940           
  Branches                        5462     5462           
==========================================================
+ Hits                           20588    20590    +2     
+ Misses                          1620     1619    -1     
+ Partials                         732      731    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some glitches, and a few questions arising

lib/iris/tests/unit/common/metadata/test_BaseMetadata.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/metadata/test_BaseMetadata.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/metadata/test_BaseMetadata.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/metadata/test_BaseMetadata.py Outdated Show resolved Hide resolved
Comment on lines 1188 to 1189
assert expected_right == result_left
assert expected_left == result_right
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert expected_right == result_left
assert expected_left == result_right
assert result_left == expected_right
assert result_right == expected_left

lib/iris/tests/unit/common/metadata/test_BaseMetadata.py Outdated Show resolved Hide resolved
@pp-mo pp-mo merged commit f1864a7 into SciTools:FEATURE_pytest_conversion Mar 22, 2024
18 checks passed
@bjlittle bjlittle deleted the pytest-common-metadata-base-metadata branch April 9, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants