Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest migration of unit.common.metadata.test_metadata_manager_factory #5876

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bjlittle bjlittle added Type: Feature Branch Highlight this for a feature branch Feature: pytest labels Mar 20, 2024
@bjlittle bjlittle requested a review from pp-mo March 20, 2024 22:49
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (c87d500) to head (8becc30).
Report is 22 commits behind head on FEATURE_pytest_conversion.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           FEATURE_pytest_conversion    #5876      +/-   ##
=============================================================
- Coverage                      89.75%   89.69%   -0.07%     
=============================================================
  Files                             92       92              
  Lines                          22940    22940              
  Branches                        5462     5462              
=============================================================
- Hits                           20590    20575      -15     
- Misses                          1619     1638      +19     
+ Partials                         731      727       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One silly question, otherwise all good 👍

@pp-mo pp-mo merged commit 47a0cd2 into SciTools:FEATURE_pytest_conversion Mar 22, 2024
19 checks passed
@bjlittle bjlittle deleted the pytest-common-metadata-factory branch April 9, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants