-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pytest migration of unit.common.resolve.test_Resolve #5882
pytest migration of unit.common.resolve.test_Resolve #5882
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_pytest_conversion #5882 +/- ##
==========================================================
Coverage 89.69% 89.69%
==========================================================
Files 92 92
Lines 22940 22940
Branches 5462 5462
==========================================================
Hits 20575 20575
Misses 1638 1638
Partials 727 727 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I've scanned this at last !
I identified just a few tweaks
@pp-mo Thanks for the review and wading through this one 💯 Back to you 👍 |
Thanks @bjlittle -- done. |
@pp-mo Thanks, you're a legend 💯 |
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: