Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest migration of unit.common.resolve.test_Resolve #5882

Merged

Conversation

bjlittle
Copy link
Member

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (9c4a9cc) to head (af9b1ef).
Report is 12 commits behind head on FEATURE_pytest_conversion.

❗ Current head af9b1ef differs from pull request most recent head 66c375a. Consider uploading reports for the commit 66c375a to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                     @@
##           FEATURE_pytest_conversion    #5882   +/-   ##
==========================================================
  Coverage                      89.69%   89.69%           
==========================================================
  Files                             92       92           
  Lines                          22940    22940           
  Branches                        5462     5462           
==========================================================
  Hits                           20575    20575           
  Misses                          1638     1638           
  Partials                         727      727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I've scanned this at last !
I identified just a few tweaks

lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/common/resolve/test_Resolve.py Outdated Show resolved Hide resolved
@bjlittle
Copy link
Member Author

bjlittle commented Apr 9, 2024

@pp-mo Thanks for the review and wading through this one 💯

Back to you 👍

@pp-mo pp-mo merged commit 3d2ac71 into SciTools:FEATURE_pytest_conversion Apr 9, 2024
18 checks passed
@pp-mo
Copy link
Member

pp-mo commented Apr 9, 2024

Thanks @bjlittle -- done.
That feels good !

@bjlittle
Copy link
Member Author

bjlittle commented Apr 9, 2024

@pp-mo Thanks, you're a legend 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: pytest Type: Feature Branch Highlight this for a feature branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants