Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More root pytest #5883

Merged

Conversation

trexfeathers
Copy link
Contributor

ruff check --select=PT compliant

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (04ed352) to head (c50b7d0).
Report is 23 commits behind head on FEATURE_pytest_conversion.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           FEATURE_pytest_conversion    #5883   +/-   ##
==========================================================
  Coverage                      89.69%   89.69%           
==========================================================
  Files                             92       92           
  Lines                          22940    22940           
  Branches                        5462     5462           
==========================================================
  Hits                           20575    20575           
  Misses                          1638     1638           
  Partials                         727      727           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers. A couple comments it'd be good to have your thoughts on, but otherwise LGTM!

lib/iris/tests/test_pp_stash.py Show resolved Hide resolved
lib/iris/tests/test_util.py Outdated Show resolved Hide resolved
lib/iris/tests/test_util.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trexfeathers, assume all tests pass happy to merge this in!

@ESadek-MO ESadek-MO merged commit bd6a9d7 into SciTools:FEATURE_pytest_conversion Mar 22, 2024
19 checks passed
@trexfeathers trexfeathers deleted the more_root_pytest branch May 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants