-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure refresh #129
Conversation
There is something slightly odd going on here... I've never quite seen it happen before. The GHA CI is being triggered and executed on my forked repo development branch, but not here on the PR. Thoughts anyone? |
Okay, just to be completely transparent here, I circumvented the branch protection on This is pretty exceptional, however the GHA CI workflows appear to be now up and running. I'm going to push a follow-on change to this PR branch to undo commit f61c2c7, which was reactive to the GHA oddness that we were experienceing. Hopefully, the CI cogs will spin as expected on this PR... |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 93.10% 97.36% +4.25%
==========================================
Files 1 7 +6
Lines 203 644 +441
Branches 50 0 -50
==========================================
+ Hits 189 627 +438
- Misses 7 17 +10
+ Partials 7 0 -7
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is all pretty spectacular. Amazing to see nc-time-axis get this kind of treatment! All these new workflows / cleanups are great. Many thanks for putting this together @bjlittle. Just a couple suggestions on some places to update the documentation.
Also please give yourself credit for this in the release notes, and if you don't mind, maybe add a note for @rcomer's work in #128 as well!
@spencerkclark Okay, over to you 👍 Note that, I ended up creating a Hopefully I've not broken anything, but do take a peek and ensure that's the case. Thanks again for taking the time to review this PR. Above and beyond. Cheers mate 🍻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thanks for the additional cleanups to the documentation!
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
@spencerkclark Back to you 👍 |
In it goes! |
🚀 Pull Request
Description
Okay... firstly, apologies 🙏
This PR is a bit of a bloater... I had some spare cycles and decided spend them by just "going-for-it":tm: and refresh all the infrastructure of
nc-time-axis
in a oner to modernize it before the technical debt caught up with us.I've been a bit opinionated in some places, but overall I don't think there is anything too controversial within this PR... and I have tried to theme the commits. Anyways, the effort is now sunk, so there you go; it's all about permission and forgiveness 😉
In summary, this PR:
cirrus-ci
and migrates to GitHub Actions (GHA) 🥳ci-citation
)conda
lock file generation (*.lock
) from top-level*.yml
environment files (ci-locks
) triggered on acron
MANIFEST.in
checking for thesdist
(ci-manifest
)pytest
over supported versions ofpython
(ci-tests
) with codecov test coverage reportingsdist
and binarywheels
(ci-wheels
)pre-commit.ci
and our hooks, rather than explicitly running the hooks ourselves in CInc-time-axis
citable (contributors please pile in and add your ORCID references)pre-commit
hooks, most notably by adopting codespell to automate spell checking of the codebase and documentationMANIFEST.in
with realityREADME.md
setup.cfg
to thepyproject.toml
nc-time-axis
codebase under thesrc
directoryconda
YAML andpip
core and optional dependencies under therequirements
directory (hopefully a better hint/reminder for devs to keep them aligned)CODECOV_TOKEN
,TEST_PYPI_API_TOKEN
andPYPI_API_TOKEN
as GHA secrets, as required by the GHAs† - Only the binary
wheels
are tested, not thesdist
. However, thewheel
is built from thesdist
using pypa/build and their recommended workflow.Yeah, I think that just about covers it. Soz. 😊
Closes #104