Fix reduction_ambition to correctly use s2 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use s2.coverage_s2 instead of s2.coverage_s1 and s2.base_year_ghg_s2 instead of s2.base_year_ghg_s1 This should cause the combined s1+s2 to correctly account for the s2 part in target.reduction_ambition calculation
mountainrambler
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use s2.coverage_s2 instead of s2.coverage_s1 and s2.base_year_ghg_s2 instead of s2.base_year_ghg_s1
This should cause the combined s1+s2 to correctly account for the s2 part in target.reduction_ambition calculation