Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix externaluid #1572

Merged
merged 6 commits into from Jun 26, 2017
Merged

Fix externaluid #1572

merged 6 commits into from Jun 26, 2017

Conversation

teleyinex
Copy link
Member

No description provided.

@teleyinex
Test to check that external_uid works.
32cf5e8 
This tests ensures that a external_uid can work even if a previous
contribution was done to the same task.
@teleyinex
Fixes #1571.
07786e0 
This PR basically takes into account the external_uid for stamping
a requested task properly (it was used the IP instead of the
external_uid).

It also adds a new method to delete the stamped task from Redis when
the taskrun has been saved, freeing memory.
@teleyinex
Increase version number.
e6f0c14
@teleyinex
Add new parameter.
2ef2bfd
@teleyinex
Fix.
3b4401f
@teleyinex
Fix test.
9155e81
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.905% when pulling 9155e81 on fix-externaluid into 3b71819 on master.

therealmarv
therealmarv approved these changes Jun 26, 2017
View reviewed changes
Copy link
Contributor

@therealmarv therealmarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.905% when pulling 9155e81 on fix-externaluid into 3b71819 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 97.905% when pulling 9155e81 on fix-externaluid into 3b71819 on master.

@teleyinex teleyinex merged commit e0bbf9b into master Jun 26, 2017
@teleyinex teleyinex deleted the fix-externaluid branch August 16, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealmarv therealmarv therealmarv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teleyinex @coveralls @therealmarv @deployments