Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to associate users with projects #186

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

aanil
Copy link
Contributor

@aanil aanil commented Nov 2, 2021

No description provided.

Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I can't find the issue I found previously.
A couple of things I noticed / thought of though (which are not neccessarily connected to the CLI but just this functionality in general):

  • dds create: At the moment the same user can be specified in the --owner and --researcher
  • dds add-user: If the user doesn't exist then it says "Invite successful" but at the moment the user is only invited to the dds in general and not the project so perhaps we should add that to the message - that they need to add the user again when they have an account or something

@aanil
Copy link
Contributor Author

aanil commented Nov 5, 2021

  • Added a check for duplicates in owners and researchers
  • Added a message clarifying that invited users need to be added to a project once they have an account.

@i-oden i-oden merged commit a0efb0d into ScilifelabDataCentre:dev Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants