Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Prompt and more #198

Merged
merged 17 commits into from
Nov 23, 2021
Merged

No Prompt and more #198

merged 17 commits into from
Nov 23, 2021

Conversation

alneberg
Copy link
Contributor

  • Implemented the --no-prompt flag to fail rather than ask for missing arguments.
  • Renamed Session to Auth everywhere
  • New subcommands: dds auth login, dds auth logout and dds auth info.
  • Removed some demo data.
  • Tiny improvements on printing logic

i-oden
i-oden reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks and works great, just a few comments and suggestions. There's currently an error when attempting to upload but that has nothing to do with this and should be fixed when my s3-info PR is merged.

dds_cli/user.py Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
dds_cli/__main__.py Outdated Show resolved Hide resolved
i-oden
i-oden approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@i-oden i-oden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and now it all works.

@i-oden i-oden merged commit 3036a97 into ScilifelabDataCentre:dev Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-oden i-oden i-oden approved these changes

@aanil aanil Awaiting requested review from aanil

Assignees

@alneberg alneberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alneberg @i-oden