Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove username #331

Merged
merged 8 commits into from
Mar 3, 2022
Merged

Remove username #331

merged 8 commits into from
Mar 3, 2022

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Mar 3, 2022 •
edited
Loading

Before submitting a PR to the dev branch:

  • Tests passing
  • Black formatting
  • Rebase/merge the dev branch
  • Note in the CHANGELOG

Additional checks before submitting a PR to the master branch:

  • Change version in setup.py (?)

@i-oden i-oden self-assigned this Mar 3, 2022
@i-oden i-oden added enhancement New feature or request should have Important but not vital labels Mar 3, 2022
@i-oden i-oden requested review from alneberg and aanil March 3, 2022 09:48
aanil
aanil approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@aanil aanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

alneberg
alneberg reviewed Mar 3, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
alneberg
alneberg approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent thank you!

@i-oden i-oden merged commit b9fdca3 into dev Mar 3, 2022
@i-oden i-oden deleted the remove-username branch March 3, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alneberg alneberg alneberg approved these changes

@aanil aanil aanil approved these changes

Assignees

@i-oden i-oden

Labels
enhancement New feature or request should have Important but not vital
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@i-oden @alneberg @aanil