-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set project as busy / not busy when uploading (1) #525
Merged
i-oden
merged 9 commits into
dev
from
DDS-1331-set-project-as-busy-when-starting-upload-not-busy-when-done
Sep 9, 2022
Merged
Set project as busy / not busy when uploading (1) #525
i-oden
merged 9 commits into
dev
from
DDS-1331-set-project-as-busy-when-starting-upload-not-busy-when-done
Sep 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-oden
commented
Sep 7, 2022
i-oden
commented
Sep 7, 2022
i-oden
commented
Sep 7, 2022
Codecov Report
@@ Coverage Diff @@
## dev #525 +/- ##
==========================================
- Coverage 42.31% 42.14% -0.18%
==========================================
Files 29 29
Lines 2595 2615 +20
==========================================
+ Hits 1098 1102 +4
- Misses 1497 1513 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
i-oden
commented
Sep 7, 2022
19 tasks
19 tasks
valyo
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After authenticating, before starting the upload, set the project as busy. When the upload is done, set as not busy again.
The
cleanup_busy_status
is placed in both the__init__
and the__exit__
because the code does not enter the__exit__
method if there's an exception during the initation of the DataPutter object.Should be tested with this PR
Fixes DDS-1331
Type of change
Checklist:
Please delete options that are not relevant.
master
branch and I have updated the versionFormatting and documentation
Tests