Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release: 2.2.64 #628

Merged
merged 29 commits into from
Apr 26, 2023
Merged

New release: 2.2.64 #628

merged 29 commits into from
Apr 26, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented Apr 25, 2023

Before submitting this PR

  1. Description: New PR to master prior to new release. This adds documentation, fixes workflows, and removes some logging.
  2. Jira task / GitHub issue: DDS-1531
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #628 (cbadbaa) into master (610312e) will decrease coverage by 0.08%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   46.64%   46.57%   -0.08%     
==========================================
  Files          31       31              
  Lines        2785     2800      +15     
==========================================
+ Hits         1299     1304       +5     
- Misses       1486     1496      +10     
Impacted Files Coverage Δ
dds_cli/file_handler_remote.py 29.54% <ø> (+2.46%) ⬆️
dds_cli/__main__.py 41.56% <26.31%> (-0.45%) ⬇️
dds_cli/version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@i-oden i-oden changed the title New release New release: 2.2.64 Apr 25, 2023
@i-oden i-oden requested a review from valyo April 25, 2023 08:08
@i-oden i-oden marked this pull request as ready for review April 25, 2023 08:14
@i-oden i-oden merged commit 6eadfe6 into master Apr 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants