Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography #635

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Bump cryptography #635

merged 2 commits into from
Jun 8, 2023

Conversation

i-oden
Copy link
Member

@i-oden i-oden commented May 25, 2023

Before submitting this PR

  1. Description: Add a summary of the changes in this PR and the related issue.
  2. Jira task / GitHub issue: Link to the github issue or add the Jira task ID here.
  3. How to test: Add information on how someone could manually test this functionality. As detailed as possible.
  4. Type of change: Check the relevant boxes in the section below
  5. Add docstrings and comments to code, even if you personally think it's obvious.

What type of change(s) does the PR contain?

  • New feature
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Bug fix
    • Breaking: Please describe the reason for the break and how we can fix it.
    • Non-breaking
  • Security Alert fix
  • Documentation
  • Tests (only)
  • Workflow

Checklist

  • Sprintlog
    • Added
    • Not needed (E.g. PR contains only tests)
  • Rebase / Update / Merge from base branch (the branch from which the current is forked)
    • Done
    • Not needed
  • Blocking PRs
    • Merged
    • No blocking PRs
  • PR to master branch

Actions / Scans

  • Black: Python code formatter. Does not execute. Only tests.
    Run black . locally to execute formatting.
    • Passed
  • Pylint: Python code linter. Does not execute. Only tests.
    Fix code producing warnings. Code must get 10/10.
    • Warnings fixed
    • Passed
  • Prettier: General code formatter. Our use case: MD and yaml mainly.
    Run npx prettier --write . locally to execute formatting.
    • Passed
  • Yamllint: Linting of yaml files.
    • Passed
  • Tests: Pytest to verify that functionality works as expected.
    • New tests added
    • No new tests
    • Passed
  • TestPyPi: Build CLI and publish to TestPyPi in order to verify before release.
    • Passed
  • CodeQL: Scan for security vulnerabilities, bugs, errors
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Trivy: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed
  • Snyk: Security scanner
    • New alerts: Go through them and either fix, dismiss och ignore. Add reasoning in items below.
    • Alerts fixed: What?
    • Alerts ignored / dismissed: Why?
    • Passed

@i-oden i-oden self-assigned this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #635 (b373de8) into dev (4b752a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #635   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files          31       31           
  Lines        2766     2766           
=======================================
  Hits         1272     1272           
  Misses       1494     1494           

@i-oden i-oden marked this pull request as ready for review May 25, 2023 11:09
@i-oden i-oden requested a review from valyo May 25, 2023 11:11
@i-oden
Copy link
Member Author

i-oden commented May 30, 2023

@valyo Also ready for review when you have time

@i-oden i-oden merged commit cd206f9 into dev Jun 8, 2023
16 checks passed
@i-oden i-oden deleted the cryptography-39.0.1 branch June 8, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants