Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Parsec able to retry first db connection, cleaner docker-compose #1258

Merged
merged 7 commits into from Jul 15, 2020

Conversation

c4ffein
Copy link
Contributor

@c4ffein c4ffein commented Jul 9, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1258 into master will increase coverage by 18.18%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1258       +/-   ##
===========================================
+ Coverage   56.97%   75.15%   +18.18%     
===========================================
  Files         298      298               
  Lines       26291    26324       +33     
===========================================
+ Hits        14979    19785     +4806     
+ Misses      11312     6539     -4773     
Impacted Files Coverage Δ
parsec/backend/postgresql/handler.py 77.08% <61.90%> (-3.54%) ⬇️
parsec/backend/cli/run.py 70.98% <100.00%> (+0.36%) ⬆️
parsec/backend/config.py 93.65% <100.00%> (+0.20%) ⬆️
parsec/backend/postgresql/factory.py 100.00% <100.00%> (ø)
parsec/core/gui/_resources_rc.py 80.00% <0.00%> (-1.25%) ⬇️
parsec/core/fs/remote_loader.py 84.75% <0.00%> (+0.44%) ⬆️
parsec/core/backend_connection/authenticated.py 96.93% <0.00%> (+0.51%) ⬆️
parsec/backend/postgresql/invite.py 96.36% <0.00%> (+0.60%) ⬆️
parsec/core/sync_monitor.py 92.01% <0.00%> (+1.26%) ⬆️
parsec/backend/client_context.py 95.89% <0.00%> (+1.36%) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90ec33...1aae82d. Read the comment docs.

Copy link
Member

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a test on this pretty easily: just start the backend with a localhost:<dummy_port> (using unused_tcp_port fixture) as postgresql configuration, then check the number of warnings we endup with thanks to recwarn fixture (see https://docs.pytest.org/en/stable/warnings.html#recwarn)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants