Test retry of failed initial db connection #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1269 +/- ##
==========================================
- Coverage 75.11% 74.62% -0.50%
==========================================
Files 298 298
Lines 26324 27233 +909
==========================================
+ Hits 19774 20322 +548
- Misses 6550 6911 +361
Continue to review full report at Codecov.
|
touilleMan
requested changes
Jul 15, 2020
tests/backend/test_postgres_db.py
Outdated
| postgresql_url = re.sub( | ||
| ":(\\d+)/", lambda m: f":{str(int(m.group()[1:-1])+1)}/", postgresql_url | ||
| ) | ||
| with pytest.raises(OSError): |
There was a problem hiding this comment.
with pytest.raises(OSError) as exc: to then test str(exc.value) == "<error message about the connection>" ?
There was a problem hiding this comment.
Did you forgot to push the changes ?
There was a problem hiding this comment.
Nope, forgot one of the UT...
touilleMan
reviewed
Jul 15, 2020
tests/backend/test_postgres_db.py
Outdated
| ): | ||
| postgresql_url = f"postgresql://localhost:{unused_tcp_port}/dummy" | ||
| with pytest.raises(OSError): | ||
| with trio.fail_after(3 * 3 + 1): |
tests/backend/test_postgres_db.py
Outdated
| postgresql_url = re.sub( | ||
| ":(\\d+)/", lambda m: f":{str(int(m.group()[1:-1])+1)}/", postgresql_url | ||
| ) | ||
| with pytest.raises(OSError): |
There was a problem hiding this comment.
Did you forgot to push the changes ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #1258 (review)