Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File history does not display authors properly #1270

Closed
AntoineDupre opened this issue Jul 15, 2020 · 3 comments
Closed

File history does not display authors properly #1270

AntoineDupre opened this issue Jul 15, 2020 · 3 comments
Assignees
Labels
C-GUI Category: Graphical User Interface issue
Projects

Comments

@AntoineDupre
Copy link
Contributor

File history does not display authors properly
history

@AntoineDupre AntoineDupre added the C-GUI Category: Graphical User Interface issue label Jul 15, 2020
@AntoineDupre AntoineDupre added this to New comers in Dev Board via automation Jul 15, 2020
@Max-7
Copy link
Contributor

Max-7 commented Jul 15, 2020

VersionLister.list() returns a UserID instead of a UserInfo.

We could use LoggedCore.get_user_info() to retrieve the human handle from the UserID but it seems to me that it would be way better to have VersionLister.list() return the UserInfo directly as it would seriously limit the number of queries made to the backend.

@c4ffein c4ffein moved this from New comers to Investigate in Dev Board Jul 15, 2020
@c4ffein c4ffein self-assigned this Jul 15, 2020
@bitlogik
Copy link
Contributor

We made some tests on Parsec 12 days ago, and we noticed that. As there are many work in progress on this topic we were not sure if this was a bug or just a remaining task to clear. Author and device are not "decoded" in the file history listing.

When you wrote "we could use LoggedCore.get_user_info() from the backend", I thought that the main goal of this obfuscated id, was to hide the real info from the server, so that the server never knows the info names. Did I miss anything?
Indeed, on top of avoiding a query to the server to get a content which is known locally, for the sake of logic, this user info should be get locally, not from the server.

@AntoineDupre AntoineDupre self-assigned this Jul 20, 2020
@c4ffein c4ffein removed their assignment Jul 20, 2020
@Max-7
Copy link
Contributor

Max-7 commented Jul 22, 2020

Fixed by #1283, closing the issue.

@Max-7 Max-7 closed this as completed Jul 22, 2020
@AntoineDupre AntoineDupre moved this from Investigate to Done in Dev Board Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-GUI Category: Graphical User Interface issue
Projects
No open projects
Dev Board
To review
Development

No branches or pull requests

4 participants