Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gui file history name #1283

Merged
merged 4 commits into from Jul 22, 2020
Merged

Fix gui file history name #1283

merged 4 commits into from Jul 22, 2020

Conversation

AntoineDupre
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited

Codecov Report

Merging #1283 into master will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
+ Coverage   81.76%   82.74%   +0.98%     
==========================================
  Files         302      302              
  Lines       26607    26961     +354     
==========================================
+ Hits        21755    22310     +555     
+ Misses       4852     4651     -201
Impacted Files Coverage Δ
parsec/core/gui/files_widget.py 77.18% <ø> (+1.24%) ⬆️
parsec/core/gui/file_history_widget.py 81.00% <100.00%> (+54.68%) ⬆️
parsec/backend/cli/run.py 67.35% <0.00%> (-3.99%) ⬇️
parsec/core/gui/_resources_rc.py 79.31% <0.00%> (-0.69%) ⬇️
parsec/backend/memory/realm.py 99.11% <0.00%> (-0.15%) ⬇️
parsec/api/protocol/realm.py 100.00% <0.00%> (ø)
parsec/api/protocol/__init__.py 100.00% <0.00%> (ø)
parsec/backend/postgresql/realm.py 100.00% <0.00%> (ø)
parsec/core/fs/workspacefs/workspacefs.py 96.28% <0.00%> (ø)
...arsec/backend/postgresql/realm_queries/__init__.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315c19e...bce4fbf. Read the comment docs.

Max-7
Max-7 reviewed Jul 21, 2020
View reviewed changes
parsec/core/logged_core.py Outdated
@@ -116,6 +116,10 @@ async def get_user_info(self, user_id: UserID) -> UserInfo:
created_on=user_certif.timestamp,
)

async def get_user_info_from_device_id(self, device_id: DeviceID) -> UserInfo:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DeviceID class has a user_id property. You don't need the get_user_info_from_device_id method and the split(), you can just call get_user_info(creator.user_id)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tip

@AntoineDupre AntoineDupre force-pushed the fix-gui-file-history-name branch 3 times, most recently from 72d895c to 009f98f Compare July 21, 2020 13:28
@AntoineDupre AntoineDupre requested a review from Max-7 July 21, 2020 13:38
@Max-7 Max-7 merged commit bcb82ac into master Jul 22, 2020
@Max-7 Max-7 deleted the fix-gui-file-history-name branch July 22, 2020 07:19
@Max-7 Max-7 mentioned this pull request Jul 22, 2020
Closed
@bitlogik bitlogik mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Max-7 Max-7 Max-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AntoineDupre @Max-7