Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and disable Splash Screen #6755

Merged
merged 2 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/capacitor.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ const config: CapacitorElectronConfig = {
},
electron: {
trayIconAndMenuEnabled: true,
splashScreenEnabled: true,
},
splashScreenEnabled: false, // sadly we are forced to disable the splash screen because of capacitor-community/electron v5.0.1
}, // see: https://github.com/capacitor-community/electron/issues/280
};

export default config;
Binary file added client/electron/assets/splash-screen.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
97 changes: 97 additions & 0 deletions client/electron/assets/splash-screen.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed client/electron/assets/splash.png
Binary file not shown.
3 changes: 2 additions & 1 deletion client/electron/capacitor.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ const config: CapacitorElectronConfig = {
},
electron: {
trayIconAndMenuEnabled: true,
splashScreenEnabled: true,
splashScreenEnabled: false, // sadly we are forced to disable the splash screen because of capacitor-community/electron v5.0.1
// see: https://github.com/capacitor-community/electron/issues/280
deepLinkingEnabled: true,
deepLinkingCustomProtocol: 'parsec3',
},
Expand Down
2 changes: 1 addition & 1 deletion client/electron/src/setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export class ElectronCapacitorApp {
*/
if (this.CapacitorFileConfig.electron?.splashScreenEnabled) {
this.SplashScreen = new CapacitorSplashScreen({
imageFilePath: join(app.getAppPath(), 'assets', this.CapacitorFileConfig.electron?.splashScreenImageName ?? 'splash.png'),
imageFilePath: join(app.getAppPath(), 'assets', this.CapacitorFileConfig.electron?.splashScreenImageName ?? 'splash-screen.png'),
windowWidth: 600,
windowHeight: 400,
});
Expand Down
Loading