Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Updated file details modal + PW tests #7229

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[MS] Updated file details modal + PW tests #7229

merged 1 commit into from
Apr 30, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Apr 29, 2024

Fixed file details modal:

  1. created and updated appear correctly
  2. the copy path option handles error
  3. the copy path option copy the full path on the system

Also added playwright tests for file details modal (and removed the cypress ones)

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes

@Max-7 Max-7 requested a review from a team as a code owner April 29, 2024 12:44
NicoTuxx
NicoTuxx approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/src/parsec/workspace.ts Show resolved Hide resolved
@Max-7 Max-7 enabled auto-merge April 30, 2024 05:29
@Max-7 Max-7 added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 0ee3327 Apr 30, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-file-details-created branch April 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Max-7 @NicoTuxx