Fix missing dependencies pin info in package-lock.json #7236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
approved these changes
Apr 30, 2024
|
|
touilleMan
reviewed
Apr 30, 2024
client/package-lock.json
Outdated
| @@ -1085,92 +1511,244 @@ | |||
| } | |||
| }, | |||
| "node_modules/@swc/core": { | |||
| "version": "1.5.0", | |||
| "version": "1.4.17", | |||
There was a problem hiding this comment.
It would be better to fix this issue by going back to the last version of package-lock.json containing the pinned versions, then re-doing whatever change introduced the removal of the pins in the first place
I have the feeling the numerous change in version in this PR are due to the fact we fixed the issue by re-pinning the version from scratch (hence losing the old pins and there precise versions)
Ironicbay
force-pushed
the
fix-missing-dependencies-info-package-lock
branch
from
0338521
to
429d255
Compare
Ironicbay
force-pushed
the
fix-missing-dependencies-info-package-lock
branch
from
429d255
to
a9e9ecc
Compare
|
Addressed among other things in #7202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7231