Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Updated how the sidebar is resized #7252

Merged
merged 2 commits into from
May 2, 2024
Merged

[MS] Updated how the sidebar is resized #7252

merged 2 commits into from
May 2, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented May 2, 2024

Closes #7241

  1. Replaces toastManager by the one from megashark-lib
  2. Updated how the sidebar resizes itself using a v-bind
  3. Update the toast offset depending on the sidebar size
  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested a review from a team as a code owner May 2, 2024 09:10
@Max-7 Max-7 added this pull request to the merge queue May 2, 2024
Merged via the queue into master with commit 6e8bbca May 2, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-bind-sidebar-size branch May 2, 2024 12:56
@Max-7 Max-7 mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ironicbay Ironicbay Ironicbay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use megashark-lib: toastManager
2 participants
@Max-7 @Ironicbay