Fix user manifest v0 creation #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 80.04% 79.91% -0.14%
==========================================
Files 263 263
Lines 21678 21743 +65
==========================================
+ Hits 17353 17375 +22
- Misses 4325 4368 +43
Continue to review full report at Codecov.
|
touilleMan
force-pushed
the
fix-user-manifest-v0-creation
branch
3 times, most recently
from
7c3fb28
to
37acf87
Compare
touilleMan
force-pushed
the
fix-user-manifest-v0-creation
branch
from
37acf87
to
b53eb9c
Compare
touilleMan
added a commit
that referenced
this pull request
Dec 4, 2019
|
CI error not related (see #811) |
Unlike other manifest, user manifest is always awaible given we can guess version 0 (only the `created` field can be considered wrong, but it will be corrected when merging with remote manifest). The previous way of lazily generating user manifest v0 create a special behavior which messed with the realm checkpoint handling code (which considers a remote modification can be safely ignored if the corresponding manifest is not in our local database...). This fix make sure the user manifest is always present in the local database and insert a generated and version 0 if it's not the case.
…due to poor event handling
…and local changes
touilleMan
force-pushed
the
fix-user-manifest-v0-creation
branch
from
87783de
to
f6c575a
Compare
Max-7
pushed a commit
that referenced
this pull request
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.