Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #147

Merged
merged 3 commits into from Nov 25, 2018
Merged

Fix CI tests #147

merged 3 commits into from Nov 25, 2018

Conversation

lafrech
Copy link
Collaborator

@lafrech lafrech commented Nov 23, 2018

  • Update flake8 config to ignore W504 (see rationale in Fix flake8 issues marshmallow-code/apispec#322).
  • Don't call fixtures directly, which is forbidden with pytest 4.
  • Don't test index version. The index version depends on the database version (and configuration). It should not be tested here. This breaks the CI tests as they are now run on MongoDB 3.4 which default to v2.

@touilleMan
Copy link
Member

What's this <CursorHold> file ?

Otherwise seems good to me 👍

@lafrech
Copy link
Collaborator Author

lafrech commented Nov 25, 2018

Oops, the <CursorHold> file was generated by vi and committed accidentally. I don't know what it is for. Removed.

@lafrech lafrech merged commit db076f6 into master Nov 25, 2018
@lafrech lafrech deleted the fix_indexes_tests branch November 25, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants