Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use async/await coroutine style in asyncio framework #179

Merged
merged 2 commits into from Mar 14, 2019

Conversation

touilleMan
Copy link
Member

No description provided.

@touilleMan touilleMan requested a review from lafrech March 14, 2019 11:21
@touilleMan touilleMan mentioned this pull request Mar 14, 2019
@coveralls
Copy link

coveralls commented Mar 14, 2019

Coverage Status

Coverage decreased (-9.7%) to 86.636% when pulling cba51a6 on move-asyncio-to-await-syntax-only into db9b4b7 on master.

@lafrech
Copy link
Collaborator

lafrech commented Mar 14, 2019

Thanks for tackling this.

Looks like you're using asynchronous comprehensions, introduced in Python 3.6:
https://docs.python.org/3/whatsnew/3.6.html#pep-530-asynchronous-comprehensions

@lafrech
Copy link
Collaborator

lafrech commented Mar 14, 2019

I fixed the 3.5 compatibility issue. Tests pass.

I can't really provide an educated review as I'm async illiterate. I'll trust you on this one and merge as is.

@lafrech lafrech added this to the 2.0 milestone Mar 14, 2019
@touilleMan touilleMan force-pushed the move-asyncio-to-await-syntax-only branch from 2a18261 to cba51a6 Compare March 14, 2019 13:41
@touilleMan
Copy link
Member Author

@lafrech hooop I didn't notice your fix !

I though we were also dropping Python 3.5 so I pushed --force and destroyed your fix ! (I should have used --force-with-lease...)

Can you re-push this branch with your fix please ?

@lafrech lafrech force-pushed the move-asyncio-to-await-syntax-only branch from cba51a6 to 2a18261 Compare March 14, 2019 13:52
@lafrech
Copy link
Collaborator

lafrech commented Mar 14, 2019

Ah ah. No pb. Done.

It takes a little more to run tests on 3.7. We need to tell Travis to use Xenial. I'll do that if you want when this is merged. #180.

Edit: see PR #181 for 3.7 support.

@touilleMan touilleMan merged commit 50b4d02 into master Mar 14, 2019
@lafrech lafrech deleted the move-asyncio-to-await-syntax-only branch March 14, 2019 16:36
@lafrech lafrech mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants